Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark all ranks known to graph when "all" is specified #1042

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

trws
Copy link
Member

@trws trws commented Jun 27, 2023

This changes the behavior a bit, in that it marks all ranks known to the database. The original tried to mark all ranks active in flux, but marked the first N. The new behavior seems more intuitive, but we may want to change it if we grow or shrink in the future.

fixes #1040

@trws trws requested a review from grondo June 27, 2023 00:09
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1042 (bd426cd) into master (32f74d6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head bd426cd differs from pull request most recent head ac204c2. Consider uploading reports for the commit ac204c2 to get more accurate results

@@          Coverage Diff           @@
##           master   #1042   +/-   ##
======================================
  Coverage    74.4%   74.4%           
======================================
  Files          86      86           
  Lines        9434    9432    -2     
======================================
- Hits         7021    7020    -1     
+ Misses       2413    2412    -1     
Impacted Files Coverage Δ
resource/modules/resource_match.cpp 72.1% <100.0%> (+<0.1%) ⬆️

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it is working as expected, thanks!

@trws trws added the merge-when-passing mergify.io - merge PR automatically once CI passes label Jun 27, 2023
@mergify mergify bot merged commit 65da8f2 into flux-framework:master Jun 27, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluxion should not use instance size to determine all ranks in resource set
2 participants