Skip to content

Commit

Permalink
Remove resource marking from feasibility init
Browse files Browse the repository at this point in the history
Problem: As a holdover from s-f-resource, s-f-feasibility marks its
         acquired resources as DOWN, which is unnecessary.

Remove the resource marking from init_resource_graph.
  • Loading branch information
jacobtkeio committed Aug 30, 2024
1 parent 3efa3f6 commit 26ac3c0
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions resource/modules/feasibility.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -290,23 +290,6 @@ static int init_resource_graph (std::shared_ptr<resource_ctx_t> &ctx)
return -1;
}

// TODO remove?
// Perform the initial status marking only when "up" rankset is available
// Rankless reader cases (required for testing e.g., GRUG) must not
// execute the following branch.
// Use ctx->update_f != nullptr to differentiate
if (ctx->update_f) {
if (mark (ctx, "all", resource_pool_t::status_t::DOWN) < 0) {
flux_log (ctx->h, LOG_ERR, "%s: mark (down)", __FUNCTION__);
return -1;
}
if (ctx->is_ups_set ()) {
if (mark (ctx, ctx->get_ups ().c_str (), resource_pool_t::status_t::UP) < 0) {
flux_log (ctx->h, LOG_ERR, "%s: mark (up)", __FUNCTION__);
return -1;
}
}
}
return 0;
}

Expand Down

0 comments on commit 26ac3c0

Please sign in to comment.