Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add false positive list for typos #5075

Closed
chu11 opened this issue Apr 7, 2023 · 1 comment
Closed

ci: add false positive list for typos #5075

chu11 opened this issue Apr 7, 2023 · 1 comment
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Apr 7, 2023

PR #5074 added a typo checker, but it is not run on all of flux-core. It'd be nice to run it everywhere, but that would require some false-positive configs to make sure all of the things we don't care about are skipped.

see https://github.com/crate-ci/typos
@chu11
Copy link
Member Author

chu11 commented Apr 7, 2023 •
edited
Loading

also there were spelling errors in sharness, ccan, parsedatetime, and libev, so could push some typo fixes to those projects too so they get pulled down eventually

edit: someone already did it in sharness
edit: bear/parsedatetime#287
edit: rustyrussell/ccan#104
edit: patch sent to libev mailing list (accepted)
edit: tap driver fixed in automake
edit: libtool https://savannah.gnu.org/support/index.php?110870

@chu11 chu11 mentioned this issue Apr 17, 2023
Closed
chu11 added a commit to chu11/flux-core that referenced this issue Apr 21, 2023
@chu11
_typos.toml: add false positive typos config
8bb1746 
Problem: The current typos workflow check only checks a select
number of files because there are so many false positives in
flux-core.

Solution: Add a _typos.toml configuration file to eliminate false
positives so we can run the typo check on all of flux-core.  The
config file either skips files with lots of false positives or
lists common false positives we wish to ignore.

Fixes flux-framework#5075
@chu11 chu11 self-assigned this Apr 21, 2023
@mergify mergify bot closed this as completed in 76a5ad9 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chu11