Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add false positive list for typos #1026

Closed
chu11 opened this issue Apr 17, 2023 · 0 comments
Closed

ci: add false positive list for typos #1026

chu11 opened this issue Apr 17, 2023 · 0 comments

Comments

@chu11
Copy link
Member

chu11 commented Apr 17, 2023 •
edited
Loading

just like flux-framework/flux-core#5075

note that vendored typos in

  • sharness
  • json.hpp

fixed upstream and could be pulled down at a later time, yggdrasil typo fixes to be sent

edit: tinloaf/ygg#10 (accepted)

edit: some typos in gnu autoconf stuffs: autoconf-archive/autoconf-archive#277 (accepted)
This was referenced Apr 18, 2023
Closed
Closed
chu11 added a commit to chu11/flux-sched that referenced this issue Apr 21, 2023
@chu11
.typos.toml: add false positive typos config
285af3c 
Problem: The current typos workflow check only checks a select
number of files because there are so many false positives in
flux-sched.

Solution: Add a .typos.toml configuration file to eliminate false
positives so we can run the typo check on all of flux-sched.  The
config file either skips files with lots of false positives or
lists common false positives we wish to ignore.

Fixes flux-framework#1026
vsoch pushed a commit to researchapps/flux-sched that referenced this issue Jul 7, 2023
@chu11 @vsoch
.typos.toml: add false positive typos config
33cf862 
Problem: The current typos workflow check only checks a select
number of files because there are so many false positives in
flux-sched.

Solution: Add a .typos.toml configuration file to eliminate false
positives so we can run the typo check on all of flux-sched.  The
config file either skips files with lots of false positives or
lists common false positives we wish to ignore.

Fixes flux-framework#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chu11