[Inspector V2] Prevent inspector tree scroll from bouncing #8367
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team
elliette
changed the title
bkonyi
reviewed
Sep 30, 2024
| @@ -990,9 +990,12 @@ class _InspectorTreeState extends State<InspectorTree> | |||
| safeViewportHeight, | |||
| ); | |||
|
|
|||
| final centerLeftHalf = Offset( | |||
There was a problem hiding this comment.
Is it worth leaving some documentation here explaining why we do this and referencing the original issue (or this PR)? ASCII art could work too ;-)
There was a problem hiding this comment.
Plus one to a comment and issue link 👍
bkonyi
approved these changes
Sep 30, 2024
kenzieschmoll
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8356
Previously we were determining whether or not to trigger a scroll based on whether the top-left and bottom-right of an item in the tree was visible.
However, for items with long descriptions, we wouldn't actually horizontally scroll to their rightmost corner, which would cause the scroll controller to trigger a scroll that didn't actually do anything.
Now we decide whether to scroll based on whether the "center left half" (red dot below) of the item is in view.