Add android app id and ios bundle id in GA metrics #8177
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangyujin
requested review from
kenzieschmoll and
chunhtai
and removed request for
elliette
chunhtai
reviewed
Aug 14, 2024
| @@ -326,6 +334,13 @@ class DeepLinksController extends DisposableController | |||
| target: target, | |||
| ); | |||
| _iosLinks[selectedAndroidVariantIndex.value] = result; | |||
| ga.impression( | |||
There was a problem hiding this comment.
yes, it's similar to ga.select but nothing is selected here.
Comment on lines
+141
to
+142
| external String? get android_app_id; | ||
| external String? get ios_bundle_id; |
There was a problem hiding this comment.
These will need to be added to the custom dimensions and metrics in the GA console for the legacy DevTools analytics if we want to track there. Otherwise they should automatically be included in the unified_analytics data for DevTools.
kenzieschmoll
approved these changes
Aug 14, 2024
1 task
|
looks like I need to update the event in pkgs/unified_analytics first, I opened PR dart-lang/tools#295 |
| this.iosBundleId, | ||
| }); | ||
|
|
||
| /// The anroid app id of the flutter project. |
There was a problem hiding this comment.
sp: android
r/flutter/Flutter (same below)
kenzieschmoll
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
please also bump the min dep of unified_analytics to ^6.1.4 to include the changes here: dart-lang/tools#295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: (#8068)
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.