[autosubmit] Do not remove label when author is a member (#2922)

This is a quality of life change. I often find myself needlessly coming back to PRs to only add the autosubmit label. Instead, I'd like to add when I open my trivial PRs.

This is to align with how Google's autosubmit works.

auto_submit/lib/validations/approval.dart

@@ -30,10 +30,10 @@ class Approval extends Validation {
 
     bool approved = false;
     String message = '';
+    Action action = Action.REMOVE_LABEL;
     if (repositoryConfiguration.autoApprovalAccounts.contains(author)) {
-      approved = true;
       log.info('PR ${slug.fullName}/${messagePullRequest.number} approved by roller account: $author');
-      return ValidationResult(approved, Action.REMOVE_LABEL, '');
+      return ValidationResult(true, Action.REMOVE_LABEL, '');
     } else {
       final GithubService githubService = await config.createGithubService(slug);
       final bool authorIsFlutterHacker =
@@ -67,12 +67,17 @@ class Approval extends Validation {
         approvedMessage = approved
             ? 'This PR has met approval requirements for merging.\n'
             : 'This PR has not met approval requirements for merging. $flutterHackerMessage and need ${approver.remainingReviews} more review(s) in order to merge this PR.\n';
+        if (!approved && authorIsFlutterHacker) {
+          // Flutter hackers are aware of the review requirements, and can add
+          // the autosubmit label without waiting on review.
+          action = Action.IGNORE_TEMPORARILY;
+        }
       }
 
       message = approved ? approvedMessage : '$approvedMessage\n${Config.pullRequestApprovalRequirementsMessage}';
     }
 
-    return ValidationResult(approved, Action.REMOVE_LABEL, message);
+    return ValidationResult(approved, action, message);
   }
 }
 

auto_submit/test/requests/check_pull_request_test.dart

@@ -755,7 +755,8 @@ void main() {
       await checkPullRequest.get();
       expectedOptions.add(flutterOption);
       verifyQueries(expectedOptions);
-      assert(pubsub.messagesQueue.isEmpty);
+      // Re-add to queue to poll for reviews
+      assert(pubsub.messagesQueue.isNotEmpty);
     });
 
     test('All messages are pulled', () async {

auto_submit/test/service/validation_service_test.dart

@@ -62,15 +62,15 @@ void main() {
     });
   });
 
-  test('Removes label and post comment when no approval', () async {
+  test('Removes label and post comment when no approval for non-flutter hacker', () async {
     final PullRequestHelper flutterRequest = PullRequestHelper(
       prNumber: 0,
       lastCommitHash: oid,
       reviews: <PullRequestReviewHelper>[],
     );
     githubService.checkRunsData = checkRunsMock;
     githubService.createCommentData = createCommentMock;
-    githubService.isTeamMemberMockMap['author1'] = true;
+    githubService.isTeamMemberMockMap['author1'] = false;
     githubService.isTeamMemberMockMap['member'] = true;
     final FakePubSub pubsub = FakePubSub();
     final PullRequest pullRequest = generatePullRequest(prNumber: 0, repoName: slug.name);

auto_submit/test/validations/approval_test.dart

@@ -99,7 +99,7 @@ void main() {
       final ValidationResult result = await computeValidationResult(review);
 
       expect(result.result, isFalse);
-      expect(result.action, Action.REMOVE_LABEL);
+      expect(result.action, Action.IGNORE_TEMPORARILY);
       expect(result.message.contains('This PR has not met approval requirements for merging.'), isTrue);
       expect(result.message.contains('need 1 more review'), isTrue);
     });
@@ -149,7 +149,7 @@ void main() {
       final ValidationResult result = await computeValidationResult(review);
 
       expect(result.result, isFalse);
-      expect(result.action, Action.REMOVE_LABEL);
+      expect(result.action, Action.IGNORE_TEMPORARILY);
       expect(result.message.contains('This PR has not met approval requirements for merging.'), isTrue);
       expect(result.message.contains('need 1 more review'), isTrue);
     });