Skip to content

Commit

Permalink
Shift RBE remote wrapper flag from config file to command line flag (#…
Browse files Browse the repository at this point in the history
…841)

The relative path in the config file is incorrect if the working
directory is not directly nested under `out/`, as will happen with
flutter/engine#51474.
  • Loading branch information
zanderso authored Mar 26, 2024
1 parent 092e19a commit 2a16784
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions build/toolchain/mac/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ if (use_goma) {
objc_prefix = "$goma_dir/gomacc "
link_prefix = "$goma_dir/gomacc "
} else if (use_rbe) {
remote_wrapper =
rebase_path("//flutter/build/rbe/remote_wrapper.sh", root_build_dir)
compiler_args = rewrapper_command + [
"--remote_wrapper=$remote_wrapper",
"--labels=type=compile,compiler=clang,lang=cpp ",
]
link_args = rewrapper_command + [
"--labels=type=link,tool=clang ",
]
cxx_prefix = string_join(" ", compiler_args)
# RBE does not support objc out of the box.
objc_prefix = ""
Expand Down

0 comments on commit 2a16784

Please sign in to comment.