Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackStage Back Button doesn't have an accessibility text. #1125

Closed
robertmuehsig opened this issue Apr 19, 2023 · 2 comments
Closed

BackStage Back Button doesn't have an accessibility text. #1125

robertmuehsig opened this issue Apr 19, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@robertmuehsig
Copy link
Contributor

If you focus the button and have the Narrator/nvda/any other screenreader open, nothing will be read:

image


Environment

  • Fluent.Ribbon v9 (and current development)
  • Windows 10/11 (doesn't matter, but the Narrator is quite "broken" on Windows 11 & WPF)
  • .NET Framework ? (just started the Showcase app).
@batzen batzen added this to the 10.0 milestone Apr 19, 2023
@batzen batzen self-assigned this Apr 19, 2023
@batzen batzen closed this as completed in 6540b87 Apr 19, 2023
@robertmuehsig
Copy link
Contributor Author

I retested it with the most recent develop branch (version 10) and at least the Windows Narrator from Windows 11 & JAWS don't read the button.

The AutomationPeers are set, but it is not working as expected:
image

batzen added a commit that referenced this issue Jul 14, 2023
batzen added a commit that referenced this issue Jul 14, 2023
@robertmuehsig
Copy link
Contributor Author

Just tested it with the most recent released version (and tested the develop branch) and it still seems broken - at least on Windows 11 with the Narrator and NVDA nothing happens when I focus the close backstage button.

I tried to fix it myself, but even when I replace the backbutton with a very simple button like this nothing happens:

                    <Button 
                            Content="Foobar"
                            Grid.Row="0"
                            Padding="22 7 0 7"
                            VerticalAlignment="Top"
                            Background="Yellow"
                            AutomationProperties.Name="Test"
                            >
                        <Button.Margin>
                            <MultiBinding Converter="{x:Static converters:StaticConverters.ThicknessConverter}">
                                <Binding Source="0" />
                                <Binding FallbackValue="0"
                                         Path="TitleBar.ActualHeight"
                                         RelativeSource="{RelativeSource FindAncestor, AncestorType={x:Type Fluent:IRibbonWindow}}" />
                                <Binding Source="0" />
                                <Binding Source="0" />
                            </MultiBinding>
                        </Button.Margin>
                    </Button>

It seems that something is blocking the narrator.

Any idea? Sorry to bother you.

@batzen batzen reopened this Jul 31, 2023
@batzen batzen modified the milestones: 10.0, 10.0.2 Jul 31, 2023
batzen added a commit that referenced this issue Aug 2, 2023
@batzen batzen closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants