Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RibbonBackButton - Localization Mix #1161

Closed
robertmuehsig opened this issue Aug 21, 2023 · 6 comments
Closed

RibbonBackButton - Localization Mix #1161

robertmuehsig opened this issue Aug 21, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@robertmuehsig
Copy link
Contributor

The "BackButton" on the Backstage has a flaw, that it mixes languages and the localization is "not ideal".

This button here:
image
... work with a screenreader since this change.

Unfortunately the German translation is "not ideal", because of the Wording "Backstage schließen".
"Backstage" itself is used by Microsoft even in German support sites, but our accessibility tester doesn't allow this, because NVDA, Jaws & the Windows Narrator have a weird pronunciation of it.

I checked if I could change the title myself to "Menü schließen", which doesn't sound too bad, but the screenreader will read "Menü schließen - Button - Open Backstage", which is weird.

The "Open Backstage" originates from the RoutedUICommand:

image, which is currently hardcoded:

public static class RibbonCommands
{
    /// <summary>
    /// Gets the value that represents the Open Backstage command
    /// </summary>
    public static readonly RoutedCommand OpenBackstage = new RoutedUICommand("Open backstage", nameof(OpenBackstage), typeof(RibbonCommands));
}

The "easiest" fix would be to change the "Backstage" to "Menü" (for the German translation) and somehow use the same text for the RoutedUICommand, but I'm not even sure if this is needed or if the text could be removed anyway.


Environment

  • Fluent.Ribbon v10
  • Windows 11
  • .NET Framework 4.8
@batzen batzen added this to the 10.0.3 milestone Aug 21, 2023
@batzen batzen self-assigned this Aug 21, 2023
@batzen batzen closed this as completed in 91ace9f Aug 22, 2023
@robertmuehsig
Copy link
Contributor Author

@batzen Ah - the "ESC" Key makes sense in this area, but the button text is still "Backstage schliessen" - any chance that you might switch to "Menü schliessen" instead?

@batzen
Copy link
Member

batzen commented Aug 22, 2023

You can overwrite that text by changing BackButtonUid. 😉

@robertmuehsig
Copy link
Contributor Author

robertmuehsig commented Aug 22, 2023 via email

@batzen
Copy link
Member

batzen commented Aug 22, 2023

It's a property on BackstageTabControl.

@robertmuehsig
Copy link
Contributor Author

@batzen Thanks - didn't noticed it, but works! Any chance that you might publish the 10.0.3 soon?

@batzen
Copy link
Member

batzen commented Aug 23, 2023

Will try to publish tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants