Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the kafka_types.go file and introduced a mapvalue struct. #1328

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheJadeLion2004
Copy link

In kvs.go, introduced an InsertValueMap function and a SecretProvider interface.

What this PR does / why we need it:

The PR attempts to change the type of the Kafka struct from a dictionary of strings to a dictionary of variant type, where the variant contains either a string or a *plugins.Secret. Needed to also change the InsertStringValueMap function and replace it by an insert MapValueMap function which does whatever the original function does, but now, tries to add elements to the map of the variant type.

An interface was used to avoid circular dependency, however there is some deepcopy error that is being generated.

Which issue(s) this PR fixes:

Fixes # #1152

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


In kvs.go, introduced an InsertValueMap function and a SecretProvider interface.

Signed-off-by: TheJadeLion2004 <[email protected]>
@TheJadeLion2004
Copy link
Author

I've created a pull request in order to check the base logic, and to get help in verifying errors. This is NOT a working PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants