-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve variable listener event query #3963
Feat: Improve variable listener event query #3963
Conversation
import java.util.Date; | ||
import java.util.GregorianCalendar; | ||
import java.util.List; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project standards are to explicitly list all imports. Please see https://github.com/flowable/flowable-engine/tree/main/ide-settings
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same note as above; thanks
import org.flowable.eventsubscription.service.impl.persistence.entity.data.impl.cachematcher.SignalEventSubscriptionByProcInstAndEventNameMatcher; | ||
import org.flowable.eventsubscription.service.impl.persistence.entity.data.impl.cachematcher.SignalEventSubscriptionByScopeAndEventNameMatcher; | ||
import org.flowable.eventsubscription.service.impl.persistence.entity.data.impl.cachematcher.SignalEventSubscriptionByScopeIdAndTypeMatcher; | ||
import org.flowable.eventsubscription.service.impl.persistence.entity.data.impl.cachematcher.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and again.
import org.flowable.eventsubscription.service.impl.persistence.entity.EventSubscriptionEntity; | ||
|
||
import java.util.Map; | ||
import java.util.Set; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the ordering of the imports; again see the ide_settings directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea settings applied ;)
@canchito-dev what kind of a problem are you trying to solve with this PR? |
Hi @filiphr |
Hi @canchito-dev , Thank you for providing the PR, we have made some modifications and did the commit in 06be453 Best regards |
Trigger querying the database table ACT_RU_EVENT_SUBSCR only if the variable that is created/updated has a variable listener event associated with it.
The change only applies to processes.
Check List: