Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back sg_trace_hooks & sg_install_trace_hooks, not sure why those were ignored #1139

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

colinbellino
Copy link
Contributor

No description provided.

@floooh
Copy link
Owner

floooh commented Oct 27, 2024

Hmm, I don't know either. The only reason I can think of is that the function pointers in the sg_trace_hooks struct break the code generation scripts, but apparently it works (but might not have worked in early versions).

Some of the other language bindings also ignore the trace hooks, others don't. But I guess if it works there's no reason to not enable them.

From my pov you can remove draft status and I can merge.

@colinbellino
Copy link
Contributor Author

I used the Odin bindgen as a base, but at least in Jai it's not an issue at all :)

@colinbellino colinbellino marked this pull request as ready for review October 27, 2024 13:58
@floooh floooh merged commit 76ded2d into floooh:master Oct 27, 2024
32 checks passed
@floooh
Copy link
Owner

floooh commented Oct 27, 2024

Oki merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants