Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gtest to v1.15.2 #625

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update gtest to v1.15.2 #625

wants to merge 2 commits into from

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Oct 11, 2024 •
edited
Loading

Update googletest to the latest version and use the GIT properties in FetchContent_Declare to avoid potential errors in handling complete URLs.

Additionally, remove custom C++ standard compile options and rely on CMAKE_CXX_STANDARD instead, which is crossplatform:

fcl/CMakeLists.txt

Line 345 in b03987c

set(CMAKE_CXX_STANDARD 14)

This change is Reviewable

@jslee02 jslee02 marked this pull request as ready for review October 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02