feat: bunny cdn integrations #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmperorOrokuSaki
force-pushed
the
develop
branch
from
2cfb61a
to
c900272
Compare
zoruka
reviewed
Jul 13, 2023
| const client = (body: string, endpoint: string) => { | ||
| if (!env.bunnyCDN.feSigningKey) { | ||
| AppLog.error('Missing BunnyCDN signing key'); | ||
| throw new Error(); |
There was a problem hiding this comment.
should we add a message to all these errors?
There was a problem hiding this comment.
seems like the async thunk already treats the error there, we should only throw the error here an treat it there with AppLog
|
|
||
| if (!env.bunnyCDN.createPullzone) { | ||
| AppLog.error('Missing BunnyCDN create pullzone endpoint'); | ||
| throw new Error(); |
|
|
||
| if (!env.bunnyCDN.verifyPullzone) { | ||
| AppLog.error('Missing BunnyCDN verify pullzone endpoint'); | ||
| throw new Error(); |
zoruka
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.