Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge flip #90

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Edge flip #90

merged 8 commits into from
Sep 26, 2024

Conversation

Oscfon
Copy link
Contributor

@Oscfon Oscfon commented Jul 11, 2024

Implement more methods for fat graphs

  • add_edge(), add_loop(): insert an isolated edge or loop
  • swap(i, j): multiply by a transposition (induces either a vertex split or merge as well as a face split or merge)
  • move_dart(i, j): reallocate dart i close to dart j

The already implemented method split_face and split_vertex can be realized using the more atomic operations swap (see the docstring of split_face and split_vertex). Though, we keep their implementations as the newly introduced methods perform relabelling.

Checklist

  • Added an entry in doc/news/.
  • Added a test for this change.

@videlec
Copy link
Contributor

videlec commented Aug 26, 2024

@Oscfon Finalement, j'ai remplacé tes fonctions par cut_vertex et glue_vertices qui sont plus générales. J'ai aussi écrit la gestion des labels et les tests. Il faudrait que tu adaptes ton code pour iso-Delaunay.

@videlec
Copy link
Contributor

videlec commented Aug 28, 2024

@Oscfon J'ai finalement factorisé avec une méthode plus générale swap(i, j). Il faut voir si on garde cut_vertex et glue_vertices qui font simplement un appel à swap.

@videlec
Copy link
Contributor

videlec commented Aug 28, 2024

Documentation complains with zenodo


URL        `https://zenodo.org/badge/latestdoi/347440823'
Name       `zenodo website'
Parent URL http://localhost:8880/surface-dynamics/, line 390, col 56
Real URL   https://zenodo.org/records/13356803
Check time 3.488 seconds
Size       13.12KB
Warning    [http-redirected] Redirected to
           `https://doi.org/10.5281/zenodo.13356803' status: 302
           FOUND.
           [http-redirected] Redirected to
           `https://zenodo.org/doi/10.5281/zenodo.13356803'
           status: 302 Found.
           [http-redirected] Redirected to
           `https://zenodo.org/records/13356803' status: 302
           FOUND.
Result     Error: 500 INTERNAL SERVER ERROR

@videlec videlec self-requested a review September 26, 2024 09:46
@videlec videlec added the enhancement New feature or request label Sep 26, 2024
@videlec videlec merged commit 7507776 into flatsurf:master Sep 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants