-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live update config file without restarting (RFC) #535
base: main
Are you sure you want to change the base?
Live update config file without restarting (RFC) #535
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 71.10% 66.75% -4.36%
==========================================
Files 41 41
Lines 2274 2292 +18
Branches 338 341 +3
==========================================
- Hits 1617 1530 -87
- Misses 552 662 +110
+ Partials 105 100 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. It looks like a cool feature and I would like to merge it in. Just one question about the implementation.
@@ -10,6 +10,7 @@ | |||
loop: | |||
active: yes | |||
sleeping_time: 600 | |||
refresh_config: no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit confused here. Doesn't setting 'refresh_config' to 'no' here actually enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think so? I just tested and it is not reloading the config when the value ist set to "no"
I just noticed that my flathunt instance is taking around 4gb of ram after running for a while. will keep you updated. |
So i wanted my instance to run on the server and while the docker container is running I can simply add URLs to the config.yaml that are automatically included in the search without needing to restart the instance.
I don't know if this function is even wanted here, but since its finished and works for me, I thought I would at least offer it.
The following functions are possible with this PR:
Steps implemented to achieve these functions:
If this feature is also useful here, but would have to be adapted before it is merged, I am open to changes.