forked from mordax7/flathunter
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Maps filter (with passing linter and type checker) #477
Open
codders
wants to merge
7
commits into
flathunters:main
Choose a base branch
from
codders:feat/google-maps-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 7, 2023
-
refactor: separate GMaps process from format
Make GMapsDurationProcessor export unformatted data as well, to enable later steps in the pipeline (such as filters) to access and process this data.
Configuration menu - View commit details
-
Copy full SHA for 1dad3d4 - Browse repository at this point
Copy the full SHA 1dad3d4View commit details
Commits on Sep 13, 2023
-
You can't re-open a NamedTemporaryFile on Windows while it's still open.
Configuration menu - View commit details
-
Copy full SHA for 1c5f36b - Browse repository at this point
Copy the full SHA 1c5f36bView commit details -
feature flathunters#472: filter based on GMaps distance
This PR involves some refactoring. The problem is that previously, filters ran before making any calls to external APIs. Therefore, just adding another filter for the distance doesn't actually work: the distance information is not yet available when we apply the filters. We can't just run the filters later, because then we would run the Google Maps API calls before we filtered out any properties, meaning that we would incur Google Maps API calls for all properties that we find in our search, including those that we later filter out anyway based on price, size, etc. - and we actually have to pay for those requests! My solution is to group the filters in two chains, and then run one chain before and one after external API calls have been made. This way, we can run the distance filter after the API calls are made, but keep everything else the same.
Configuration menu - View commit details
-
Copy full SHA for 8a85d82 - Browse repository at this point
Copy the full SHA 8a85d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74d41fc - Browse repository at this point
Copy the full SHA 74d41fcView commit details
Commits on Sep 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0f45f3 - Browse repository at this point
Copy the full SHA e0f45f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5e2841 - Browse repository at this point
Copy the full SHA d5e2841View commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7277162 - Browse repository at this point
Copy the full SHA 7277162View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.