Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build v3.14.0 using QT 6 #164

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Build v3.14.0 using QT 6 #164

merged 4 commits into from
Sep 17, 2024

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Jun 28, 2024

Nextcloud client is transitioning to QT6 as QT5 is end of life. My build instructions are based on the changes from nextcloud/desktop#4584 which does not have a stable nextcloud client release yet, so I am currently building from main branch.

The nextcloud client can be built and runs properly. Migrating to QT6 fixes the issues many people (including me) experienced with the deprecated/EOL QT5 runtime.

ncdesktop

To the maintainers: The issues around missing elements have not been fixed for quite some time. I cannot afford dedicating large parts of my freetime to this project, but if you are interested in me supporting you maintaining the client, consider reaching out to me, as I also provided a PR for the last visual flatpak runtime issues: #130

@flathubbot
Copy link
Contributor

Started test build 131037

@flathubbot
Copy link
Contributor

Build 131037 failed

@p-fruck
Copy link
Contributor Author

p-fruck commented Jun 28, 2024

errors: [flathub-json-automerge-enabled]

Any maintainer has an idea why this happens? Building works fine locally using flatpak run org.flatpak.Builder --user --install ./build-dir/ com.nextcloud.desktopclient.nextcloud.yml

@flathubbot
Copy link
Contributor

Started test build 136184

@flathubbot
Copy link
Contributor

Build 136184 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/119223/com.nextcloud.desktopclient.nextcloud.flatpakref

@hpfr
Copy link

hpfr commented Aug 12, 2024

errors: [flathub-json-automerge-enabled]

Any maintainer has an idea why this happens? Building works fine locally using flatpak run org.flatpak.Builder --user --install ./build-dir/ com.nextcloud.desktopclient.nextcloud.yml

This appears to be why: Linter breaking change: restricting automatic merge | Flathub Documentation.

The automerge-flathubbot-prs feature has been introduced back in 2019 to reduce maintenance overhead of applications dependent on non-redistributable data. If an extra-data source used by the app disappears because of an update, the automation would ensure that it is still possible to install the app, without requiring manual intervention from the maintainers.

Over time, the feature has started to be misused as a general purpose automation for publishing updates without proper testing. This has led to a number of issues where apps became broken overnight, which could have been easily prevented if the update was tested before merging.

The Nextcloud manifest does not seem to use any extra-data sources, so you can probably update the commit message with this link.

Automatic merging has been disabled by the flathub linter, see
https://docs.flathub.org/blog/linter-restricting-automatic-merge/
@flathubbot
Copy link
Contributor

Started test build 140000

@p-fruck
Copy link
Contributor Author

p-fruck commented Aug 13, 2024

@hpfr thanks for the hint, I updated the commit message

@flathubbot
Copy link
Contributor

Build 140000 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123037/com.nextcloud.desktopclient.nextcloud.flatpakref

@flathubbot
Copy link
Contributor

Started test build 147368

@flathubbot
Copy link
Contributor

Build 147368 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/130462/com.nextcloud.desktopclient.nextcloud.flatpakref

@p-fruck p-fruck changed the title Preview: Build using QT 6 Build v3.14.0 using QT 6 Sep 17, 2024
@p-fruck
Copy link
Contributor Author

p-fruck commented Sep 17, 2024

@tilosp From my point of view this PR is ready merge with the recent release of Nextcloud 3.14.0. What do you think?

@tilosp tilosp merged commit 549eaa9 into flathub:master Sep 17, 2024
1 check passed
@tilosp
Copy link
Collaborator

tilosp commented Sep 17, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants