Skip to content

Commit

Permalink
Add Python 3.12 wheels/fix some sdist build problems (#78)
Browse files Browse the repository at this point in the history
Summary:
Resolves #76.

### Test Plan (required)
CI + CIBW + local wheel test

### Checklist

- [x] Test coverage
- [x] Tests pass
- [x] Code formatted
- [x] Rebased on latest matter
- [x] Code documented

Pull Request resolved: #78

Reviewed By: bwasti

Differential Revision: D54173813

Pulled By: jacobkahn

fbshipit-source-id: 747adf9380bdf261e0d54b8e16d7e8a457eea578
  • Loading branch information
jacobkahn authored and facebook-github-bot committed Feb 26, 2024
1 parent 6bc3192 commit eb60ae0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: '3.12'

# Use a venv for macOS runners
- name: "Create Python virtual environment"
Expand All @@ -27,7 +27,7 @@ jobs:
if: runner.os == 'macOS'

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.12.1
run: python -m pip install cibuildwheel==2.16.5
- name: Compute version
run: echo "$(python bindings/python/compute_version.py)" > BUILD_VERSION.txt
- name: Build wheels
Expand All @@ -52,7 +52,7 @@ jobs:
run: echo "BUILD_VERSION=$(python bindings/python/compute_version.py)" >> $GITHUB_ENV

- name: Build sdist
run: pipx run build --sdist --no-isolation
run: pipx run build --sdist

- uses: actions/upload-artifact@v3
with:
Expand Down
5 changes: 5 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@ recursive-include cmake *.cmake *.cmake.in
recursive-include flashlight/lib *.h *.cpp CMakeLists.txt
recursive-include bindings/python *.cpp CMakeLists.txt
global-exclude *.o *.so *.dylib *.a .git *.pyc *.swp

include LICENSE
include bindings/python/version.txt
include bindings/python/README.md
include requirements.txt

0 comments on commit eb60ae0

Please sign in to comment.