Staging minor convenience functions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! I'm excited to see what's coming next 😉 Shall I merge this already? Or do you want to keep on working on this PR? (either is fine for me) |
|
merging this as it's a prerequisite to #27 which will remain open for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Floris!
Minor
bugs addededits made towards #9 [Apologies for my previous frenetic reply there:)], figured I'd break up the PRs.This hasn't been extensively tested beyond units and lints, just pulled out of master; if it looks satisfactory you can keep it open until the next PR if you like.
Thanks for this great lib!