-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "lite" version (js only, without CSS) #269
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4bb7621
Add support for negative CSS values
egirard 192b0c8
Merge branch 'master' of https://github.com/egirard/scroll-timeline
egirard 4f24b57
Merge branch 'master' of https://github.com/egirard/scroll-timeline
egirard 5188a38
Adds "lite" version (js only)
egirard 617f292
Merge branch 'flackr:master' into master
egirard 8057b5f
Rename build-js to build-lite for consistency
egirard 0a62254
Merge branch 'master' of https://github.com/egirard/scroll-timeline
egirard 774b9b8
Remove dist.lite directory
egirard abc4d41
Update expected.txt
egirard 15ea511
Cleanup
egirard 4ed714f
Update expectations
egirard 012c7ff
Purge references to dist-lite
egirard fc6a497
Cleanup (remove diagnostic output)
egirard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright 2024 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import { initPolyfill } from "./init-polyfill.js" | ||
|
|
||
| initPolyfill(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import { | ||
| ScrollTimeline, | ||
| ViewTimeline, | ||
| } from "./scroll-timeline-base"; | ||
| import { | ||
| animate, | ||
| elementGetAnimations, | ||
| documentGetAnimations, | ||
| ProxyAnimation | ||
| } from "./proxy-animation.js"; | ||
|
|
||
| import { initCSSPolyfill } from "./scroll-timeline-css" | ||
|
|
||
| export function initPolyfill() { | ||
| // Don't load if browser claims support | ||
| if (window.ViewTimeline !== undefined) { | ||
| return true; | ||
| } | ||
|
|
||
| if ( | ||
| !Reflect.defineProperty(window, 'ScrollTimeline', { value: ScrollTimeline }) | ||
| ) { | ||
| throw Error( | ||
| 'Error installing ScrollTimeline polyfill: could not attach ScrollTimeline to window' | ||
| ); | ||
| } | ||
| if ( | ||
| !Reflect.defineProperty(window, 'ViewTimeline', { value: ViewTimeline }) | ||
| ) { | ||
| throw Error( | ||
| 'Error installing ViewTimeline polyfill: could not attach ViewTimeline to window' | ||
| ); | ||
| } | ||
|
|
||
| if ( | ||
| !Reflect.defineProperty(Element.prototype, 'animate', { value: animate }) | ||
| ) { | ||
| throw Error( | ||
| "Error installing ScrollTimeline polyfill: could not attach WAAPI's animate to DOM Element" | ||
| ); | ||
| } | ||
| if (!Reflect.defineProperty(window, 'Animation', { value: ProxyAnimation })) { | ||
| throw Error('Error installing Animation constructor.'); | ||
| } | ||
| if (!Reflect.defineProperty(Element.prototype, "getAnimations", { value: elementGetAnimations })) { | ||
| throw Error( | ||
| "Error installing ScrollTimeline polyfill: could not attach WAAPI's getAnimations to DOM Element" | ||
| ); | ||
| } | ||
| if (!Reflect.defineProperty(document, "getAnimations", { value: documentGetAnimations })) { | ||
| throw Error( | ||
| "Error installing ScrollTimeline polyfill: could not attach WAAPI's getAnimations to document" | ||
| ); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| export function buildConfig(source, filename) { | ||
| return { | ||
| build: { | ||
| sourcemap: true, | ||
| emptyOutDir: false, | ||
| lib: { | ||
| // Could also be a dictionary or array of multiple entry points | ||
| entry: source, | ||
| name: 'ScrollTimeline', | ||
| // the proper extensions will be added | ||
| fileName: (format, entryAlias) => `${filename}${format=='iife'?'':'-' + format}.js`, | ||
| formats: ['iife'], | ||
| }, | ||
| minify: 'terser', | ||
| terserOptions: { | ||
| keep_classnames: /^((View|Scroll)Timeline)|CSS.*$/ | ||
| }, | ||
| rollupOptions: { | ||
| output: { | ||
| // Provide global variables to use in the UMD build | ||
| // for externalized deps | ||
| globals: { | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
| }; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,5 @@ | ||
| import { resolve } from 'path' | ||
| import { defineConfig } from 'vite' | ||
| import { buildConfig } from './vite.config.common' | ||
|
|
||
| export default defineConfig({ | ||
| build: { | ||
| sourcemap: true, | ||
| lib: { | ||
| // Could also be a dictionary or array of multiple entry points | ||
| entry: resolve(__dirname, 'src/index.js'), | ||
| name: 'ScrollTimeline', | ||
| // the proper extensions will be added | ||
| fileName: (format, entryAlias) => `scroll-timeline${format=='iife'?'':'-' + format}.js`, | ||
| formats: ['iife'], | ||
| }, | ||
| minify: 'terser', | ||
| terserOptions: { | ||
| keep_classnames: /^((View|Scroll)Timeline)|CSS.*$/ | ||
| }, | ||
| rollupOptions: { | ||
| output: { | ||
| // Provide global variables to use in the UMD build | ||
| // for externalized deps | ||
| globals: { | ||
| }, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| export default defineConfig(buildConfig(resolve(__dirname, 'src/index.js'), 'scroll-timeline')); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { resolve } from 'path' | ||
| import { defineConfig } from 'vite' | ||
| import { buildConfig } from './vite.config.common' | ||
|
|
||
| export default defineConfig(buildConfig(resolve(__dirname, 'src/index-lite.js'), 'scroll-timeline-lite')); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about this. If the browser supports the CSS API's but not the JS ones maybe we should still polyfill the JS apis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to check with
typeof ScrollTimeline !== "undefined"(andViewTimeline) here indeed.