Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #244
Adding another PR for discussion:
The
svg-graphics-element
tests are currently flaky, making the tests fail randomly when submitting PRs.This is due to three separate issues:
auto
durationThe first two issues are easy to solve, but the third is more complicated.
The polyfill waits for
animationstart
before polyfilling animations. At this point the wpt test might have started already, causing the test to fail or time out.It is possible to proxy the
promise_test()
function, so that it waits for the polyfill before running the test. However, the wpt test runner only allows one injected script. To make the test pass then we either have to:It seems like several others polyfill projects have run into similar problems (web-platform-tests/wpt#38227). I wish it was possible to inject multiple scripts into the wpt test runner, but that might not be feasible.