Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised upload page #1255

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Revised upload page #1255

wants to merge 4 commits into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Sep 2, 2024

  • removed moment.js package (apparently unused for quite a while)
  • revised upload page:
    • replaced "select" elements on upload page with dropdown menus
    • inputs are always visible
    • changed the styling to be more coherent
    • removed validity check (it is not possible to send an invalid request using the unedited upload page because of the required tags)
      • it could be possible to send an invalid request by manually crafting one but that would only generate an error in the frontend
    • added optional filter inputs for device classes, names and vendors
    • added custom autocomplete menus for inputs with dropdown menu

@maringuu
Copy link
Collaborator

Nice!

Can we make the right arrow trigger the list of all possible entries?
The dropdown search on the right looks redundant to me.
image

…ogging

the check_for_errors method is not useful anymore, since all non-optional form fields are 'required' (meaning you cannot click on 'submit' if they are missing) and if they are missing, we get a BadRequestKeyError anyway

the improved error logging for BadRequestKeyError will show which key is missing (otherwise it would fail silently)
replaced bootstrap selects with dropdowns and made styling more coherent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants