Add Package Configuration #4
Conversation
|
Can you add docs to the README to explain how one might use this when constructing their commands image? |
| WORKDIR /the/workdir/path | ||
| ENV ALADDIN_COMMANDS_PATH='/the/workdir/path/commands_base_example' | ||
|
|
||
| COPY pyproject.toml ./ |
There was a problem hiding this comment.
We should also demonstrate copying the poetry.lock file over, too
There was a problem hiding this comment.
added it as a comment, I did not want to commit that file here because it's basically a duplicate of the lock file in the repo root, which also makes this example harder to maintain when dependencies change
There was a problem hiding this comment.
Can't we commit a dummy file here with a comment in it saying that it's a placeholder?
There was a problem hiding this comment.
hmm so I don't see how a dummy file is an improvement over the comment in the line below, if using a blank dummy file with just a comment in it then the example is broken because poetry will complain about the lock file being out of sync with .toml, this way at least the example is pretty much ready to go, in any case I don't think we're aiming for this to be a poetry how-to
This PR adds package configuration so that the
aladdin_commandexecutable can be installed using pip and poetry.Should be as easy as:
poetry add git+https://github.com/fivestars-os/[email protected]