Make the concatener a Readable and upload to google chunk by chunk #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
commented
Jun 18, 2020
Comment on lines
+132
to
+138
| ctx.req.on('aborted', () => { | ||
| log.debug('request-aborted', 'The request has been aborted!'); | ||
| concatener.unpipe(googleStorageStream); | ||
| const error = new BadRequestError('The request has been aborted.'); | ||
| googleStorageStream.destroy(error); | ||
| concatener.destroy(error); | ||
| }); |
There was a problem hiding this comment.
From my test this doesn't seem to make a big difference. But this does no harm 🤷
julienw
commented
Jun 18, 2020
| this.chunks.length = 0; | ||
| callback(); | ||
| } | ||
|
|
||
| transferContents(): Buffer { |
There was a problem hiding this comment.
I kept this one for tests, as it's still useful in that context. But we shouldn't use it for the production code.
I wonder if I should add a check for NODE_ENV==='test'... That wouldn't work when running tests obviously but we'd see it when running integration tests. Thoughts?
|
I've thought about this a bit more, this may be just easier to do the work I planned to generate a token before starting to upload, effectively removing the need to concatenate the content. I think i'll try this next week and see if I can get it to work with a small amount of work. |
|
Superceded by #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change halves memory usage during an upload by avoiding a copy, by giving the data to the google stream chunk by chunk instead of all at once (checked using top). This also seems to recover memory better when aborting big requests (but I'll have to double check this).
The first commit is #89, please don't look at it.
This might fix #83 incidentally but I haven't tried yet, I'll do before requesting review.
I already tested with a real profile end-to-end.
There's seem to still have a small leak, but I'm not sure yet. That's why I'm not requesting a review yet.