You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Concatenator works by keeping all chunks in an array, and concatenating them all when the stream is ended. Then we keep and return this result when transferContents is called. The result is also cleared when the stream is destroy.
Node v14 now autodestroys stream by default when it ends.
The easy option is to force autoDestroy to true in the constructor.
A better option could be to output the result at the end like a stream, simply pushing the result of the concatenation. Possibly we would need to use objectMode for this too, so that node handles this result as one object instead of a big chunk. This would make the object more true to how streams work, and in the end more compatible with this mechanism in the long run.
The text was updated successfully, but these errors were encountered:
The Concatenator works by keeping all chunks in an array, and concatenating them all when the stream is ended. Then we keep and return this result when
transferContents
is called. The result is also cleared when the stream is destroy.Node v14 now autodestroys stream by default when it ends.
The easy option is to force autoDestroy to true in the constructor.
A better option could be to output the result at the end like a stream, simply pushing the result of the concatenation. Possibly we would need to use objectMode for this too, so that node handles this result as one object instead of a big chunk. This would make the object more true to how streams work, and in the end more compatible with this mechanism in the long run.
The text was updated successfully, but these errors were encountered: