Fix a crash where fonts randomly become unavailable #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninarg
requested review from
a team,
AtishPapa and
Breiby
and removed request for
a team
bstien
approved these changes
Jun 20, 2024
Breiby
approved these changes
Jun 20, 2024
No idea 🤷 mystery |
|
@Breiby Figured out why legendary is working. There we do a double registering of fonts, so we do it in FinniversKit, but also add the fonts as "Fonts provided by application" to Info.plist. So legendary would fallback on that one and not crash. So seems like I might not have to merge this PR, but rather fix it on the other side (add fonts to the main project for FINN NMP and Tori). |
|
Wow, nice catch! 💪 |
|
Closing this one, we found an alternative way to solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We have a crash in Tori and FINN NMP related to fonts. The problem is that some fonts suddenly "disappear" from memory a while after having been successfully loaded on app startup, so our force unwrap of the FINN font will crash the app.
What?
We found a consistent way to reproduce this:
I found this thread of others experiencing the same issue. The last post includes a fix, where you use another method for registering fonts based on URL. Currently we are using this method to register fonts:
CTFontManagerRegisterGraphicsFont, but the fix is to switch toCTFontManagerRegisterFontsForURL, where you are able to specify a scope.There's a scope called
.processwhich means the font will be available for the lifetime of "the process" which registered it, e.g. it needs to be registered once after every restart of the app, as we already do.After having changed to
CTFontManagerRegisterFontsForURL, the app does not crash anymore when following the steps above, so it seems to fix it. 🤞Version Change
Minor.