Merge pull request #8 from finn-no/fix/reset-method

Reset method animates to max height instead of offset
finn-no · Nov 27, 2019 · 93c93af · 93c93af
2 parents 042efd8 + e5f9e9e
commit 93c93af
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -6,7 +6,7 @@ jobs:
     shell: /bin/bash --login -o pipefail
     steps:
       - checkout
-      - run: xcodebuild -project BottomSheet.xcodeproj -scheme "Demo" -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=13.2.2,name=iPhone 11 Pro' build test | xcpretty
+      - run: xcodebuild -project BottomSheet.xcodeproj -scheme "Demo" -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=13.3,name=iPhone 11 Pro' build test | xcpretty
 
   swiftlint:
     docker:
@@ -20,4 +20,4 @@ workflows:
   build-and-test:
     jobs:
       - swiftlint
-      - build-and-test
+      - build-and-test
diff --git a/Sources/BottomSheetView.swift b/Sources/BottomSheetView.swift
@@ -141,12 +141,7 @@ public final class BottomSheetView: UIView {
     /// Call this method e.g. when orientation change is detected.
     public func reset() {
         updateTargetOffsets()
-
-        guard let maxOffset = targetHeights.max() else {
-            return
-        }
-
-        animate(to: maxOffset)
+        animate(to: targetOffsets[currentTargetOffsetIndex])
     }
 
     /// Animates bottom sheet view to the given height.