Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoded keys/credentials/etc #999

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Add encoded keys/credentials/etc #999

merged 1 commit into from
Oct 9, 2018

Conversation

vkostyukov
Copy link
Collaborator

To accomodate #995.

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #999 into master will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   83.37%   83.99%   +0.62%     
==========================================
  Files          50       50              
  Lines         854      856       +2     
  Branches       51       54       +3     
==========================================
+ Hits          712      719       +7     
+ Misses        142      137       -5
Impacted Files Coverage Δ
core/src/main/scala/io/finch/endpoint/path.scala 96% <0%> (+0.34%) ⬆️
core/src/main/scala/io/finch/Input.scala 100% <0%> (+9.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd98c95...3e24ae2. Read the comment docs.

Copy link
Contributor

@arron-green arron-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@arron-green
Copy link
Contributor

@vkostyukov should we change this PR to merge into the WIP branch in #995 rather than master?

@vkostyukov
Copy link
Collaborator Author

@vkostyukov should we change this PR to merge into the WIP branch in #995 rather than master?

Let's merge these two PRs into the same branch (off of master) and keep iterating there.

@vkostyukov vkostyukov changed the base branch from master to auto-releases October 9, 2018 17:16
@vkostyukov vkostyukov merged commit 3079e72 into auto-releases Oct 9, 2018
@vkostyukov vkostyukov deleted the vk/enc-files branch October 9, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants