Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto releases #1000

Merged
merged 12 commits into from
Oct 9, 2018
Merged

Enable auto releases #1000

merged 12 commits into from
Oct 9, 2018

Conversation

vkostyukov
Copy link
Collaborator

@vkostyukov vkostyukov commented Oct 9, 2018

@arron-green and I spent some time working on this. We're putting everything together to see how it looks.

Fixes #977.

Follow up work:

Also 🎉 for the 1000th PR!

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #1000 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   83.41%   83.37%   -0.04%     
==========================================
  Files          50       50              
  Lines         856      854       -2     
  Branches       51       51              
==========================================
- Hits          714      712       -2     
  Misses        142      142
Impacted Files Coverage Δ
core/src/main/scala/io/finch/endpoint/path.scala 95.65% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd98c95...66067cd. Read the comment docs.

@vkostyukov
Copy link
Collaborator Author

@arron-green Thanks again for instigating this!

What our next steps should be in your opinion?

.travis.yml Outdated Show resolved Hide resolved
build/build.sh Outdated Show resolved Hide resolved
.travis.yml Outdated
- 2.11.12
- 2.12.6
- 2.11.12
- 2.12.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to 2.12.7? build.sbt currently points to 2.12.7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, we totally should.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pro for tossing away a build matrix is we never have to do that again.

sudo: false
branches:
except:
- release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arron-green Do you know what's release branch is for?

@vkostyukov
Copy link
Collaborator Author

I think it's ready to go. The only question I have is how do we test it? Perhaps we could just wait for the next release and see how it goes.

@vkostyukov vkostyukov mentioned this pull request Oct 9, 2018
2 tasks
@vkostyukov vkostyukov changed the base branch from master to cats-effect October 9, 2018 22:30
@vkostyukov
Copy link
Collaborator Author

I rebase that against cats-effect - it will be merged there.

@vkostyukov vkostyukov merged commit 9ed30f3 into cats-effect Oct 9, 2018
@vkostyukov vkostyukov deleted the auto-releases branch October 10, 2018 00:30
@arron-green
Copy link
Contributor

I think it's ready to go. The only question I have is how do we test it? Perhaps we could just wait for the next release and see how it goes.

Sounds good. Glad i could help motivate this issue! Excited to see the result of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants