Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Use a concrete release of singularity for integration test #151

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

gammazero
Copy link
Collaborator

Fixes #147

Running tests locally works:

✔ Volume "motionlarity_motion-singularity-volume"        Created   0.0s
 ✔ Container motionlarity-db-1                            Healthy  0.0s
 ✔ Container motionlarity-singularity_admin_init-1        Exited   0.0s
 ✔ Container motionlarity-singularity_content_provider-1  Started  0.0s
 ✔ Container motionlarity-singularity_deal_pusher-1       Started  0.0s
 ✔ Container motionlarity-singularity_deal_tracker-1      Started  0.0s
 ✔ Container motionlarity-singularity_dataset_worker-1    Started  0.0s
 ✔ Container motionlarity-singularity_api-1               Started  0.0s
✔ Container motionlarity-motion-1                        Started

Run Motion integration tests
MOTION_INTEGRATION_TEST='true' go test . -v --count=1
=== RUN   TestRoundTripPutStatusAndFullStorage
    integration_test.go:43: check existing deals
    integration_test.go:59: clearing boost publish queue
    integration_test.go:68: posting 8MB data into motion
    integration_test.go:75: {16901881-fc9b-48a2-ad19-07df40b8ac70}
    integration_test.go:80: requesting data back while still in source storage
    integration_test.go:92: waiting for singularity to make deals with boost
    integration_test.go:108: waiting for singularity to transfer data to boost
    integration_test.go:124: triggering data publish in boost
    integration_test.go:134: awaiting successful deal publishing
    integration_test.go:153: sleeping for 1 minute to allow cleanup worker to run, and indexing to complete
--- PASS: TestRoundTripPutStatusAndFullStorage (121.68s)
PASS
ok      github.com/filecoin-project/motion/integration/test     122.057s

@gammazero gammazero requested a review from masih October 5, 2023 22:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #151 (d9890ba) into main (c38b9f6) will decrease coverage by 0.13%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   31.83%   31.70%   -0.13%     
==========================================
  Files           5        5              
  Lines         735      738       +3     
==========================================
  Hits          234      234              
- Misses        466      469       +3     
  Partials       35       35              

see 1 file with indirect coverage changes

@masih
Copy link
Member

masih commented Oct 6, 2023

Looks like CI is failing to fetch images?

Error response from daemon: Head "https://ghcr.io/v2/data-preservation-programs/singularityv0.5.0/manifests/latest": denied

@gammazero gammazero marked this pull request as draft October 6, 2023 20:26
@gammazero gammazero marked this pull request as ready for review October 10, 2023 23:10
@gammazero
Copy link
Collaborator Author

OK, got this working. Turns out that the singularity build is not tagging images in ghcr for tagged versions. So, I just use the image tag :main which is whatever the latest build in the main branch is. If that is really what we want, then this is all good. If we want to refer to a specific tagged release then we will need to tag singularity images.

@masih
Copy link
Member

masih commented Oct 11, 2023

Turns out that the singularity build is not tagging images in ghcr for tagged versions

Are we sure? Looks like it does.

Looking at this commit it looks like a v is missing in the tag name?

@gammazero
Copy link
Collaborator Author

gammazero commented Oct 11, 2023

@masih I thought I had tried both with and without "v". Anyhow, the testing with the v0.5.0 image fails always, and testing with the :main image succeeds. I think we need to tag a new Singularity release.

@masih
Copy link
Member

masih commented Oct 11, 2023

Interesting... I can't see why this is happening. I'll take a closer look tomorrow to see if i can understand what's happening.

In the meantime, of course. Please feel free to tag a release.

@gammazero
Copy link
Collaborator Author

Tagged a newer singularity release, and used that. Works.

@gammazero gammazero merged commit 2b43d7d into main Oct 12, 2023
7 checks passed
@gammazero gammazero deleted the test-singularity-tagged-release branch October 12, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move integration tests to use a concrete release of singularity
3 participants