Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Add integration test for full deal flow, fix retrieval bugs #118

Merged
merged 12 commits into from
Oct 5, 2023

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Sep 12, 2023

Goals

Write an integration test that verifies data is actually sent into singularity and deals are proposed to boost. Test retrieval including:

  • Test the retrieval process from both the datasource and Filecoin.
  • Verify the correct functioning of the read seeker.
  • Test the HTTP endpoint for file retrieval.
  • Verify Lassie integration and CAR file retrieval.

fixes #103

Implementation

  • Various bug fixes already shipped and merged to singularity discovered in testing
  • Move most execution of devnet integration test out of github action into a Makefile. See integration/test/README.md for more information. This enables running tests and devnets locally with ease
  • Switch from SINGULARITY_TAG to SINGULARITY_REF, removing the automatically inserted colon. This allows us to run from direct SHA tags as needed. It also means the code will run is no ref is specified, as opposed to before where it would fail if no SINGULARITY_TAG was present
  • Fix bug with go-routine execution of singularity preparation introduced in cleanup data PR
  • Fix bug with blob descriptors when local file is deleted
  • Fix bug where local data was deleted before the deal status was published or active
  • Add several hook scripts to enable acceptance of boost deals (such as pricing deals to zero)
  • Various configuration fixes to make dealmaking in test run smoothly
  • Integration test that now does a MUCH more full cycle -- pushes, retrieves, waits for full storage on filecoin, then retrieves with Lassie

For discussion

  • I had to add a custom entrypoint boost in order to properly configure boost to advertise booster-http. We should probably upstream this.

  • There is a bug fix for singularity that should get in before we merge this.

@hannahhoward hannahhoward force-pushed the feat/integration-test-with-status branch 3 times, most recently from 8df3747 to e192634 Compare September 15, 2023 18:23
@hannahhoward hannahhoward force-pushed the feat/integration-test-with-status branch 4 times, most recently from 047ce6d to 10c0c50 Compare September 21, 2023 21:09
@hannahhoward hannahhoward marked this pull request as ready for review September 21, 2023 21:09
@hannahhoward hannahhoward force-pushed the feat/integration-test-with-status branch from 10be003 to 5dcef6b Compare September 22, 2023 03:35
@hannahhoward hannahhoward changed the title Add integration test for status Add integration test for full deal flow, fix retrieval bugs Sep 23, 2023
Copy link
Contributor

@elijaharita elijaharita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! so glad we are getting this

looks good to me, i don't see anything to suggest except for a log typo, haha

integration/test/buildsingularity.sh Outdated Show resolved Hide resolved
@masih masih force-pushed the feat/integration-test-with-status branch from 8250295 to b894341 Compare October 5, 2023 08:01
@masih masih merged commit f870783 into main Oct 5, 2023
7 checks passed
@masih masih deleted the feat/integration-test-with-status branch October 5, 2023 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieval Testing and Verification
3 participants