This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Add integration test for full deal flow, fix retrieval bugs #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/integration-test-with-status
branch
3 times, most recently
from
September 15, 2023 18:23
8df3747
to
e192634
Compare
hannahhoward
force-pushed
the
feat/integration-test-with-status
branch
4 times, most recently
from
September 21, 2023 21:09
047ce6d
to
10c0c50
Compare
hannahhoward
force-pushed
the
feat/integration-test-with-status
branch
from
September 22, 2023 03:35
10be003
to
5dcef6b
Compare
hannahhoward
changed the title
Add integration test for status
Add integration test for full deal flow, fix retrieval bugs
Sep 23, 2023
elijaharita
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! so glad we are getting this
looks good to me, i don't see anything to suggest except for a log typo, haha
also cleans up various issues
Co-authored-by: Elijah <[email protected]>
masih
force-pushed
the
feat/integration-test-with-status
branch
from
October 5, 2023 08:01
8250295
to
b894341
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Write an integration test that verifies data is actually sent into singularity and deals are proposed to boost. Test retrieval including:
fixes #103
Implementation
integration/test/README.md
for more information. This enables running tests and devnets locally with easeFor discussion
I had to add a custom entrypoint boost in order to properly configure boost to advertise booster-http. We should probably upstream this.
There is a bug fix for singularity that should get in before we merge this.