fix: getMsgInfo returns an ErrNotFound when there are no rows #12680
+71
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
virajbhartiya
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
rvagg
reviewed
Nov 7, 2024
Comment on lines
+104
to
+113
| for { | ||
| mi, err = s.GetMsgInfo(ctx, msgCid) | ||
| if err == nil { | ||
| break | ||
| } | ||
| if ctx.Err() != nil { | ||
| t.Fatalf("timed out waiting for message to appear: %v", err) | ||
| } | ||
| time.Sleep(50 * time.Millisecond) | ||
| } |
There was a problem hiding this comment.
see require.Eventually() to do this with a bit more robustness
although, I'm not sure this test case adds much, what unique coverage are we adding with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #12674
Proposed Changes
GetMsgInfo returns an ErrNotFound when there are no rows.
Checklist