Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release Lotus node and miner v1.30.0-rc1 #12564

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 7, 2024

Related Issues

#12480

Proposed Changes

Prepping the first release candidate for v1.30.0

Checklist

Before you mark the PR ready for review, please make sure that:

@rjan90 rjan90 changed the title chore: prep Node and Miner v1.30.0-rc1 changelog build: release Lotus node and miner v1.30.0-rc1 Oct 7, 2024
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Oct 7, 2024
@rjan90 rjan90 mentioned this pull request Oct 7, 2024
@BigLep
Copy link
Member

BigLep commented Oct 7, 2024

Mental note for me: this PR will target release/v1.30.0 when the branch has been created per https://filecoinproject.slack.com/archives/CP50PPW2X/p1728329352168609

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
chore: prep v1.30.0-rc1 changelog
Co-Authored-By: Steve Loeppky <[email protected]>
@rjan90 rjan90 changed the base branch from master to release/v1.30.0 October 8, 2024 09:28
chore: bump version to v1.30.0-rc1
@rjan90 rjan90 marked this pull request as ready for review October 8, 2024 09:35
chore: Changelog add contributors and update date
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small suggestion for having a compare statement that calls out Node and Miner so this changelog entry can work for both branches/releases: #12564 (comment)

Chore: compare to the compare to the tag in Changelog
@rjan90
Copy link
Contributor Author

rjan90 commented Oct 8, 2024

It seems like the Check (docs-check) has gotten stuck when trying to report its status. From the gen-check I can confirm that this has passed: https://github.com/filecoin-project/lotus/actions/runs/11238659846/job/31243936701?pr=12564, I will therefor bypass that check.

Screenshot 2024-10-08 at 18 08 25

@rjan90 rjan90 merged commit d09aaa5 into release/v1.30.0 Oct 8, 2024
100 checks passed
@rjan90 rjan90 deleted the phi/v1300-rc1-prep branch October 8, 2024 16:09
rjan90 added a commit that referenced this pull request Oct 11, 2024
* chore: prep v1.30.0-rc1 changelog

chore: prep v1.30.0-rc1 changelog
Co-Authored-By: Steve Loeppky <[email protected]>

* chore: bump version to v1.30.0-rc1

chore: bump version to v1.30.0-rc1

* chore: Changelog add contributors and update date

chore: Changelog add contributors and update date

* Chore: compare to the compare to the tag in Changelog

Chore: compare to the compare to the tag in Changelog

---------

Co-authored-by: Steve Loeppky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants