-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(f3): update go-f3 to 0.4.0 #12547
Conversation
bcb292e
to
fdde9b7
Compare
2024-10-02 converation: marked as draft because it has a commit-based dependency. It will move to "Ready for review" once have a released version can depend against. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine 👍
My vote would be to cut a release in F3 before merging and bubble it up
Agreed - lets do it right. We're going to get enforcement of only having released versions in Lotus dependency tree when #7131 gets done. Before we have it, it would be good for maintainers to comply :). |
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
fdde9b7
to
7eceef2
Compare
Updated, but now I need to figure out why the itest is failing. |
Didn't set the catch-up alignment so it defaulted to 1 instance per 15s (way too slow). |
Hm. I got an interesting failure locally: PauseAndRebootstrap failed with:
I'm guessing it's because we stopped/restarted? This'll probably be fixed by the WAL integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
SGTM |
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing by F3. As a result this build parameter no longer has any effect. Remove it. Relates to: #12547
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing by F3. As a result this build parameter no longer has any effect. Remove it. Relates to: #12547
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing by F3. As a result this build parameter no longer has any effect. Remove it. Relates to: #12547
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing by F3. As a result this build parameter no longer has any effect. Remove it. Relates to: #12547
No description provided.