Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(f3): update go-f3 to 0.4.0 #12547

Merged
merged 7 commits into from
Oct 3, 2024
Merged

chore(f3): update go-f3 to 0.4.0 #12547

merged 7 commits into from
Oct 3, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Oct 2, 2024

No description provided.

@BigLep BigLep changed the title Updat go-f3 to 0.4.0 Update go-f3 to 0.4.0 Oct 2, 2024
@Kubuxu Kubuxu requested review from Stebalien and masih October 2, 2024 15:06
@BigLep
Copy link
Member

BigLep commented Oct 2, 2024

2024-10-02 converation: marked as draft because it has a commit-based dependency. It will move to "Ready for review" once have a released version can depend against.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine 👍

My vote would be to cut a release in F3 before merging and bubble it up

@BigLep
Copy link
Member

BigLep commented Oct 2, 2024

My vote would be to cut a release in F3 before merging and bubble it up

Agreed - lets do it right. We're going to get enforcement of only having released versions in Lotus dependency tree when #7131 gets done. Before we have it, it would be good for maintainers to comply :).

Signed-off-by: Jakub Sztandera <[email protected]>
@Stebalien
Copy link
Member

Updated, but now I need to figure out why the itest is failing.

@Stebalien
Copy link
Member

Updated, but now I need to figure out why the itest is failing.

Didn't set the catch-up alignment so it defaulted to 1 instance per 15s (way too slow).

@Stebalien
Copy link
Member

Hm. I got an interesting failure locally: PauseAndRebootstrap failed with:

2024-10-03T10:52:24.052-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1001, "instance": 4, "round": 0, "phase": "QUALITY"}
2024-10-03T10:52:24.052-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1002, "instance": 4, "round": 0, "phase": "QUALITY"}
2024-10-03T10:52:24.052-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1000, "instance": 4, "round": 0, "phase": "QUALITY"}
2024-10-03T10:52:24.052-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1003, "instance": 4, "round": 0, "phase": "QUALITY"}
2024-10-03T10:52:24.093-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1001, "instance": 4, "round": 0, "phase": "PREPARE"}
2024-10-03T10:52:24.093-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1000, "instance": 4, "round": 0, "phase": "PREPARE"}
2024-10-03T10:52:24.093-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1002, "instance": 4, "round": 0, "phase": "PREPARE"}
2024-10-03T10:52:24.094-0700    WARN    f3      [email protected]/equivocation.go:87 local self-equivocation detected     {"sender": 1003, "instance": 4, "round": 0, "phase": "PREPARE"}

I'm guessing it's because we stopped/restarted? This'll probably be fixed by the WAL integration.

@Stebalien Stebalien marked this pull request as ready for review October 3, 2024 18:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien Stebalien changed the title Update go-f3 to 0.4.0 chore(f3): update go-f3 to 0.4.0 Oct 3, 2024
@github-actions github-actions bot dismissed their stale review October 3, 2024 18:36

PR title now matches the required format.

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Oct 3, 2024
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 3, 2024

SGTM

@Stebalien Stebalien removed the skip/changelog This change does not require CHANGELOG.md update label Oct 3, 2024
@Stebalien Stebalien enabled auto-merge (squash) October 3, 2024 18:44
@Stebalien Stebalien merged commit 0e7292a into master Oct 3, 2024
81 checks passed
@Stebalien Stebalien deleted the feat/f3-update-v0.4.0 branch October 3, 2024 18:50
masih added a commit that referenced this pull request Oct 21, 2024
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing
by F3. As a result this build parameter no longer has any effect. Remove
it.

Relates to: #12547
masih added a commit that referenced this pull request Oct 21, 2024
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing
by F3. As a result this build parameter no longer has any effect. Remove
it.

Relates to: #12547
rjan90 pushed a commit that referenced this pull request Oct 24, 2024
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing
by F3. As a result this build parameter no longer has any effect. Remove
it.

Relates to: #12547
rjan90 pushed a commit that referenced this pull request Oct 28, 2024
Upgrade to `go-f3` `v0.4.0` removed the option to disable checkpointing
by F3. As a result this build parameter no longer has any effect. Remove
it.

Relates to: #12547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

4 participants