Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: curio: storage filter based on miner ID #11801

Merged
merged 4 commits into from
Apr 4, 2024
Merged

feat: curio: storage filter based on miner ID #11801

merged 4 commits into from
Apr 4, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Apr 1, 2024 •
edited
Loading

Related Issues

Proposed Changes

This PR introduces the miner ID based filters for storage in lotus-miner and Curio. The filter can be used to ensure that a particular storage only accepts sectors from "AllowMiners" list or deny sectors from "DenyMiners" list.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr requested review from magik6k and snadrus April 1, 2024 19:13
@LexLuthr LexLuthr mentioned this pull request Apr 1, 2024
Closed
19 tasks
snadrus
snadrus requested changes Apr 1, 2024
View reviewed changes
storage/paths/index.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from snadrus April 2, 2024 20:41
magik6k
magik6k reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, couple of simple to address comments

lib/harmony/harmonydb/sql/20240401-storage-segregation.sql Outdated Show resolved Hide resolved
storage/paths/db_index.go Outdated Show resolved Hide resolved
storage/paths/db_index.go Outdated Show resolved Hide resolved
storage/paths/db_index.go Outdated Show resolved Hide resolved
storage/sealer/storiface/filetype.go Show resolved Hide resolved
storage/sealer/storiface/filetype.go Outdated Show resolved Hide resolved
storage/sealer/storiface/filetype.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from magik6k April 4, 2024 13:42
magik6k
magik6k reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple last nitpicks + lets try to get the CI green

cmd/curio/tasks/tasks.go Outdated Show resolved Hide resolved
curiosrc/ffi/task_storage.go Outdated Show resolved Hide resolved
curiosrc/piece/task_park_piece.go Outdated Show resolved Hide resolved
storage/paths/db_index.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit a24028c into master Apr 4, 2024
185 checks passed
@magik6k magik6k deleted the curio/miner-storage branch April 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@snadrus snadrus Awaiting requested review from snadrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LexLuthr @snadrus @magik6k