Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio: refactor curio graceful shutdown #11794

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Mar 28, 2024

Related Issues

Proposed Changes

The gracefulshutdown() has been refactored to ensure that all Posts complete before shutdown.
We no longer have a 1 hour hard timeout and as soon as all Post related tasks are finished, the node is terminated.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr mentioned this pull request Mar 28, 2024
19 tasks
lib/harmony/harmonytask/harmonytask.go Outdated Show resolved Hide resolved
lib/harmony/harmonytask/harmonytask.go Outdated Show resolved Hide resolved
lib/harmony/harmonytask/harmonytask.go Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from snadrus March 29, 2024 07:03
@snadrus snadrus merged commit 8062f20 into master Mar 30, 2024
184 checks passed
@snadrus snadrus deleted the curio/shutdown-refactor branch March 30, 2024 16:40
Nagaprasadvr pushed a commit to Nagaprasadvr/lotus that referenced this pull request Apr 4, 2024
* refactor curio shutdown

* apply suggestions, remove provider cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants