feat: zeorize support #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this doesn't actually compile yet. Given that |
|
It does compile, but maybe you can indicate if there are some improvements in the code, @dignifiedquire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds specific support for the Zeroize crate.
In particular, it allows the
PrivateKeystruct to deriveZeroize.This translates into having the possibility to have secure PrivateKeys
since they won't leak any information if the memory address is accessed
after the variable is dropped.
The functionality relies on the fact that the crate
bls12_381alsoimplements Zeorize, so nothing in the API has changed.
Solves #74