aherbert bug fixes #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sub-classes of the CustomMesh to be exported
The methods previously ignored the default orientation of y-downwards. Thus they could not be used to reset the view to match the default view returned by reset view command.
This will reset to the same directory as that used for save since the SaveDialog is called with the default name and the directory is left to be the default directory.
Showing the pop-up on mouse press and release is redundant. Just do it on mouse released.
This is used when the menubar has been updated.
The BoundingBox could throw an exception when the content added to an image had identical min and max coordinates, e.g. a single point. This has required updating the POM to bring in the JOGL runtime for the test. This can be removed if the test is deemed trivial.
|
Thank you @aherbert, and sorry for the delay in reply. I will be out of the office for the next two weeks, and am still not caught up on post-travel tasks from last time, so unfortunately it may be awhile before I get to reviewing and merging this. But I will do so as soon as I can—it's in my queue. |
melloware
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes for the 3D viewer.
One bug could be demonstrated using a JUnit test so I have added dependencies to the POM to allow it to be run. The fix to the actual class is trivial and so the test could be removed as no other tests are present in the package.
Some changes are not bug fixes but extensions to the public API to expose more functionality in the Image3DUniverse and the view window.