Changing a note on attestation #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2020
eldanb
reviewed
Oct 11, 2021
| are likely to obtain consent from the user for other types of attestation | ||
| conveyances, which likely results in a larger fraction of unsuccessful | ||
| credential creations due to users canceling the creation). | ||
|
|
There was a problem hiding this comment.
I think it makes sense to also note that when asking for attestation there may be some UX concerns (I believe some browsers, at least in some versions, display specific warning when attestation is requested by the browser...?)
And that if using attestations the RP should be prepared to a case where an authenticator is being used that's not listed in MDS or otherwise known to the RP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many RPs whose business are for consumers and who do need attestation.
So changed the note for attestation to provide choices for RPs to select depending on their priorities, by showing
pros and cons on attestation.
Since the same note was repeated 5 times, I added it to the foot note section for removing the redundancy.