fix "failed to open required file" for config file #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix "failed to open required file" When we use this package (with laravel) inside phar archive. The problem happen because realpath will return the full path when the package no longer exist in disk. With this pull request the path will be relative and will work inside phar archive.
|
Any idea on if this'll break for those not using it within a phar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix "failed to open required file" When we use this package (with laravel) inside phar archive.
The problem happen because realpath will return the full path when the package no longer exist in disk.
With this pull request the path will be relative and will work inside phar archive.