Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin core refactor #763

Merged
merged 28 commits into from
Sep 29, 2022
Merged

Spin core refactor #763

merged 28 commits into from
Sep 29, 2022

Commits on Sep 29, 2022

  1. Replace log with tracing in spin-redis 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0de1d49 View commit details
    Browse the repository at this point in the history

  2. Copy spin-core and spin-app crates from prototype 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    216a5f7 View commit details
    Browse the repository at this point in the history

  3. Create spin-trigger-new crate 

    This will replace spin-trigger in a future commit.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    fa434a9 View commit details
    Browse the repository at this point in the history

  4. Migrate spin-config to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2be489f View commit details
    Browse the repository at this point in the history

  5. Migrate outbound-http to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ad71a33 View commit details
    Browse the repository at this point in the history

  6. Migrate outbound-pg to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    81a3629 View commit details
    Browse the repository at this point in the history

  7. Migrate outbound-redis to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a9de5f2 View commit details
    Browse the repository at this point in the history

  8. Migrate spin-http to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    548efa3 View commit details
    Browse the repository at this point in the history

  9. Migrate spin-redis to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    24eebf4 View commit details
    Browse the repository at this point in the history

  10. Migrate spin-timer example to new core 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d3e48dd View commit details
    Browse the repository at this point in the history

  11. Rename spin-trigger-new crate to spin-trigger 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6f4e0e6 View commit details
    Browse the repository at this point in the history

  12. Remove 'allow_transient_write' from spin-loader 

    This functionality is now handled in spin-core by mounting files with
write capabilites disabled.

Various tidying in the vicinity of removals.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a41c40c View commit details
    Browse the repository at this point in the history

  13. Update spin up to use new spin-trigger semantics 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    eea88f9 View commit details
    Browse the repository at this point in the history

  14. Remove spin-engine crate 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    db22636 View commit details
    Browse the repository at this point in the history

  15. Canonicalize file paths in spin-trigger 

    File URIs are supposed to be absolute.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    be8d94d View commit details
    Browse the repository at this point in the history

  16. Print failed response body in integration tests 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b0edd46 View commit details
    Browse the repository at this point in the history

  17. Improve error reporting in spin_app::Error 

    The `:#` formatting modifier causes anyhow::Error to print the full list
of causes / contexts.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f9a8219 View commit details
    Browse the repository at this point in the history

  18. Improve TriggerLoader::load_module error 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b1873d4 View commit details
    Browse the repository at this point in the history

  19. Use 'url' crate to manage file URLs 

    Treating them as strings works fine for *nix OSes, but breaks for
Windows.

Also, standardize on "URL" vs "URI" in spin-trigger crate.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a9f7f5f View commit details
    Browse the repository at this point in the history

  20. Replace OwnedApp Deref with explicit 'borrowed' method 

    The Deref impl used a scary unsafe lifetype cast which was hard to
reason about and unsound for use within the spin-app crate.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ce6f0ef View commit details
    Browse the repository at this point in the history

  21. Add ValuesMapBuilder::take 

    ValuesMapBuilder::build is updated to have the more idiomatic behavior
of consuming the builder, while 'take' adopts 'build's old behavor of
resetting the builder to empty.

Also add doc comments to all ValuesMapBuilder methods.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    85bab18 View commit details
    Browse the repository at this point in the history

  22. Add documentation to spin-core crate 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b21f185 View commit details
    Browse the repository at this point in the history

  23. Add docs to spin-app crate 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ddd85b7 View commit details
    Browse the repository at this point in the history

  24. Remove '--include-ignored' from Makefile 

    It isn't clear why this was included in the first place and it doesn't
appear to be used now.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c1f831d View commit details
    Browse the repository at this point in the history

  25. Deduplicate App::get_metadata, AppComponent::get_metadata 

    Also add AppComponent::require_metadata for interface consistency.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6934177 View commit details
    Browse the repository at this point in the history

  26. Deduplicate App::get_metadata, AppComponent::get_metadata 

    Also add AppComponent::require_metadata for interface consistency.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    47a89c7 View commit details
    Browse the repository at this point in the history

  27. Add tests to spin-core crate 

    Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    4ee7dc7 View commit details
    Browse the repository at this point in the history

  28. Fix --temp 

    The new trigger code expects the working directory to be absolute, which
is the case for tempdirs but not necessarily `--temp`. Fix by
`.canonicalize()`ing the work dir.

Signed-off-by: Lann Martin <[email protected]>
    @lann
    lann committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c12caa5 View commit details
    Browse the repository at this point in the history