Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include component dependencies in OCI artifact #2893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include component dependencies in OCI artifact #2893

wants to merge 1 commit into from
+25 −0

Conversation

itowlson
Copy link
Contributor

Fixes #2891.

@fibonacci1729 @vdice this is rather "works on my machine" at the moment; do you have any thoughts on how to rassle it into a test harness?

fibonacci1729
fibonacci1729 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm also not sure about how to add a test harness or how best to test this. Nonetheless, manually tested so it at least works on 2 machines! 🪅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@vdice vdice Awaiting requested review from vdice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise error when trying to push app with local dependencies
2 participants
@itowlson @fibonacci1729