Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract pg client #2651

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Abstract pg client #2651

merged 1 commit into from
Jul 25, 2024

Conversation

calebschoepp
Copy link
Collaborator

@calebschoepp calebschoepp commented Jul 15, 2024 •
edited
Loading

Closes #2649

@lann lann changed the base branch from main to factors July 15, 2024 21:13
rylev
rylev reviewed Jul 16, 2024
View reviewed changes
crates/factor-outbound-pg/src/client.rs Outdated Show resolved Hide resolved
crates/factor-outbound-pg/src/client.rs Outdated Show resolved Hide resolved
crates/factor-outbound-pg/src/client.rs Outdated Show resolved Hide resolved
crates/factor-outbound-pg/src/lib.rs Show resolved Hide resolved
crates/factor-outbound-pg/tests/factor_test.rs Show resolved Hide resolved
crates/factor-outbound-pg/src/host.rs Outdated Show resolved Hide resolved
@calebschoepp calebschoepp requested a review from rylev July 25, 2024 17:58
@calebschoepp calebschoepp marked this pull request as ready for review July 25, 2024 17:58
@calebschoepp
Copy link
Collaborator Author

This is ready for review. Feel free to take it over and merge it while I'm gone on vacation @lann @rylev

lann
lann approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes

crates/factor-outbound-pg/src/client.rs Outdated Show resolved Hide resolved
crates/factor-outbound-pg/src/client.rs Outdated Show resolved Hide resolved
@lann lann merged commit 774ac14 into fermyon:factors Jul 25, 2024
2 checks passed
@rylev rylev mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann approved these changes

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebschoepp @lann @rylev