Add TextNow recipe #416
Closed
Add TextNow recipe #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2023 14:31
SpecialAro
requested changes
Sep 3, 2023
Comment on lines
+2
to
+8
| class Messenger extends Ferdium { | ||
| overrideUserAgent() { | ||
| return window.navigator.userAgent | ||
| .replaceAll(/(Ferdium|Electron)\/\S+ \([^)]+\)/g, '') | ||
| .trim(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Is this needed? If not, please remove it
Comment on lines
+80
to
+86
| localStorage.setItem( | ||
| '_cs_desktopNotifsEnabled', | ||
| JSON.stringify({ | ||
| __t: Date.now(), | ||
| __v: true, | ||
| }), | ||
| ); |
Comment on lines
+88
to
+104
| if (typeof Ferdium.onNotify === 'function') { | ||
| Ferdium.onNotify(notification => { | ||
| if (typeof notification.title !== 'string') { | ||
| notification.title = | ||
| ((notification.title.props || {}).content || [])[0] || 'Messenger'; | ||
| } | ||
|
|
||
| if (typeof notification.options.body !== 'string') { | ||
| notification.options.body = | ||
| (((notification.options.body || {}).props || {}).content || [])[0] || | ||
| ''; | ||
| } | ||
|
|
||
| return notification; | ||
| }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This code is interesting 🤔
Why do you need it? Did you by any chance noticed that the title or body could be different from string and that would cause an error?
|
Hi @Arthur-Huan! Did you close this PR by accident? |
|
No, I realized some of the files were the wrong ones. It's kind of a mess on my computer and I must have mixed some files up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Adding the recipe for TextNow.