-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Excalidraw recipe #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should have 2 recipes for Excalidraw. Other than the serviceURL
, what else is different?
Pretty much nothing for the recipe, but having only one recipe makes it harder for either free or paid users I think. Say we put as a default the URL of the free version, paid users will have to type in the URL manually. |
you can add a self-hosted option in the recipe's package.json for them to then configure it |
They will still have to write the URL manually. Actually the best thing I’m thinking about is providing the package.json with an array of URLs and having Ferdium to ask which URL to use when configuring the service, but it would require changes in Ferdium as well. |
Well I’ll make the free version the default one and add a self-hosted option. |
Fix linting issue (from another PR)
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Closes ferdium/ferdium-app#1223