Fix WhatsApp count

[victorbnl]

Pre-flight Checklist

Please ensure you've completed all of the following.

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.

Description of Change

See ferdium/ferdium-app#1182 (comment)

[vraravam]

Please bump the version in the package.json specific to this recipe

[victorbnl]

I’m changing the fix though, as I figured out another issue whilst testing (chat.muteExpiration) doesn’t always exist. Then I’ll bump the version number

[victorbnl]

Finally I will stick to chat.archive, it’s not outdated, it just doesn’t exist on some chats (as with chat.muteExpiration for that matter), and chat.isAutoMuted doesn’t tell the archived state of a chat. However I changed the condition so it won’t be a problem if one is undefined.

[AvremelM]

Finally I will stick to chat.archive, it’s not outdated, it just doesn’t exist on some chats (as with chat.muteExpiration for that matter), and chat.isAutoMuted doesn’t tell the archived state of a chat. However I changed the condition so it won’t be a problem if one is undefined.

@victorbnl
What happened to this? The code isn't using chat.archive anymore, and I have 6000+ unreads now 😂

[victorbnl]

That’s a lot! Could you go to the service developer console (by pressing Alt+Ctrl+Shift+I) into the “Application” tab, then expand “IndexedDB”, then “model-storage”, then “chat”, and look at some entries to see if they have muteExpiration and isAutoMuted attributes and check their values? An example of an entry that is archived but meets the following condition would be helpful: chat.muteExpiration > 0 || chat.isAutoMuted.

[AvremelM]

@victorbnl
No problem.
I'm looking at some of the muted/archive groups I have and I see

{
  archive: true,
  //...
  isAutoMuted: false,
  muteExpiration: -1,
  //...
  unreadCount: 3123,
}

I think the muteExpiration: -1 is "infinite", i.e. when you tell it to never turn back on.
Perhaps the condition should be chat.muteExpiration !== 0

[victorbnl]

Yes, that has been dealt with in: #408 (recipe version 3.5.2).

[AvremelM]

Oh, perfect, thanks!