Add badge count support to AirMessage recipe #367
Conversation
|
(By the way, Contributing Guidelines file is gone!) |
There was a problem hiding this comment.
I am not using this service so I cannot verify if this will work appropriately. However, I think that relying on the font weight of elements is prone to break and I would recommend finding a more robust approach for the future. If this still works and you think that is at the moment the best way, I will be fine with it though.
On another note, please make sure to run the tests as described there before you push the next changes, and this should be done before submitting a PR as well so that linting and errors are caught as early as possible.
| let count = 0; | ||
| let messageNameElements = document.getElementsByClassName("MuiTypography-body1"); | ||
| if (messageNameElements.length > 0) { | ||
| for (i = 0; i < messageNameElements.length; i++) { |
There was a problem hiding this comment.
Please fix this for loop. I would suggest making it more robust by using the automatic loops (in the like of for (var element of messageNameElements) which makes the test on the previous line unnecessary as well.
vraravam
force-pushed
the
update-airmessage
branch
from
544d776
to
dd6c125
Compare
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change