Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Office 365 Outlook service #353

Closed
wants to merge 1 commit into from

Conversation

Thelm76
Copy link

@Thelm76 Thelm76 commented May 4, 2023

update domain from live.com to office.com

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

@Thelm76
Copy link
Author

Thelm76 commented May 4, 2023

Hi, I've not run any tests yet (just changed the URL in my local service)

The Contributing guidelines link is dead, so I assume I should look at here

Also, I didn't see ant policy regarding version numbers, so I also assumed that changing the service url is a relatively major change, so I bumped to 1.7.0

@Alphrag
Copy link
Member

Alphrag commented May 5, 2023

Hi @Thelm76 thanks for the PR.
However, I don't think we will change that at the moment. Indeed, the usage of either urls live.com and office.com seem to be the norm. I don't know which one is globally more present than the other, but both are definitely very common. For this reason, we added the "self-hosting" setting for that recipe so that users could set the domain name that correspond to the account they connect to (I personally use both domains as the different emails I log in behave differently). Changing now which one is the default would disconnect some users which are currently staying connected.

@Alphrag
Copy link
Member

Alphrag commented May 5, 2023

The Contributing guidelines link is dead, so I assume I should look at here

Yes, a few people have noticed it, since we moved over some code between the ferdium-recipes and the ferdium-app repo. The idea would be to have a contributing document that link to the one in ferdium-app for the initial setting, as well as the documentation specific to updating recipes that you linked. Feel free to make a PR to improve the docs.

@Thelm76
Copy link
Author

Thelm76 commented May 15, 2023

Oh I see... I hadn't tested with my former live address and yup' it doesn't work... Easiest setting for users would be to have a 3-buttons selection at setup (as it is not very clear that we have to switch from live.com to office.com)...

@Thelm76
Copy link
Author

Thelm76 commented May 15, 2023

I'll work on this when I get some time to dig in

update domain from live.com to office.com

Update package.json

Update package.json
@vraravam vraravam force-pushed the fix/office365_outlook_domain branch from c551b3e to c6bf541 Compare June 29, 2023 01:49
@mcmxcdev
Copy link
Contributor

Hey @Thelm76, any chance that you can finish up this PR? Otherwise, I will close it.

@vraravam
Copy link
Contributor

vraravam commented Jun 7, 2024

Closing due to inactivity

@vraravam vraravam closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants